Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix label column incorrectly added by feature extractors in RAI Vision dashboard for automl models #2532

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

imatiach-msft
Copy link
Contributor

@imatiach-msft imatiach-msft commented Feb 8, 2024

Description

fix label column incorrectly added by feature extractors in RAI Vision dashboard for automl models

One of our customers was not able to run error analysis when attaching to compute instance due to label column being incorrectly included in the RAI Vision dashboard extracted metadata. They encountered the error:

Traceback (most recent call last):
  File "/azureml-envs/responsibleai-vision/lib/python3.8/site-packages/raiwidgets/responsibleai_dashboard_input.py", line 182, in debug_ml
    filtered_data_df = self._prepare_filtered_error_analysis_data(
  File "/azureml-envs/responsibleai-vision/lib/python3.8/site-packages/raiwidgets/responsibleai_dashboard_input.py", line 166, in _prepare_filtered_error_analysis_data
    raise UserConfigValidationException(
Feature label not found in dataset. Existing features: <REMOVED>
...

This seems to be an issue that occurs only for automl models due to the extra "image_details" column which is not skipped in the logic of extract_features function.
This PR fixes the errors and adds both a unit test for the extract_features function and an e2e test for the RAI vision dashboard on the fridge dataset.
I was also able to reproduce the error for our AutoML notebook. Note when viewing image metadata we see the extra label column which should not be included:

image

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

2 similar comments
@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (13d30c5) 87.85% compared to head (59b2b8e) 78.52%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2532      +/-   ##
==========================================
- Coverage   87.85%   78.52%   -9.33%     
==========================================
  Files         144       36     -108     
  Lines        8042     2612    -5430     
==========================================
- Hits         7065     2051    -5014     
+ Misses        977      561     -416     
Flag Coverage Δ
unittests 78.52% <100.00%> (-9.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imatiach-msft imatiach-msft merged commit 973631d into main Feb 9, 2024
97 checks passed
@imatiach-msft imatiach-msft deleted the ilmat/fix-feat-ext-label-added branch February 9, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants