Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payload body checker can't handle bodies that don't start with '{' #67

Closed
rifiles opened this issue Nov 18, 2020 · 2 comments · Fixed by #120
Closed

Payload body checker can't handle bodies that don't start with '{' #67

rifiles opened this issue Nov 18, 2020 · 2 comments · Fixed by #120
Labels
bug Something isn't working

Comments

@rifiles
Copy link
Collaborator

rifiles commented Nov 18, 2020

Payload body checker can't handle bodies that don't start with '{'.

For instance, if a body is a list, which is still valid json, it will fail.

It fails first because it can't find the body (doesn't start with '{').
If the above is handled for '[' it will behave incorrectly because it assumes the body will always start with a key value pair, so the replacement bodies are created like this: "": [ "..." ] instead of simply [ "..." ]

@rifiles rifiles added the bug Something isn't working label Nov 18, 2020
@marina-p
Copy link
Contributor

@rifiles Is the missing functionality just to handle json arrays?

@rifiles
Copy link
Collaborator Author

rifiles commented Nov 19, 2020

@rifiles Is the missing functionality just to handle json array

Pretty much, yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants