Change to an activity based timeout #1289
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1052
Fixes #118 (comment)
The request Timeout used to cover the time until the response headers were received, which may also include sending the request body. This timeout could be problematic for large requests or gRPC client streaming. There was no timeout on the response body or on WebSockets which risked a resource leak.
Now a single activity token and timeout is used to track 'liveness', where that timeout is reset any time there's observable progress such as:
What doesn't count:
This way we're not limiting the size of a request nor the direction of the traffic, so long as there continues to be any traffic.
Server request and response body data rates may still apply (though we opt out of those for gRPC & Kestrel).
(Thanks to @MihaZupan's last change, this was pretty easy 馃榿, with many of the changes being aesthetic.)