Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing QueryTransformContext query collection to be case insensitive #1553

Merged
merged 2 commits into from
Feb 9, 2022

Conversation

jerry-shao
Copy link
Contributor

This PR will change the query collection of QueryTransformContext to be case insensitive which will be consistent with ASP.NET.

This PR fixes the bug mentioned in issue: 1496

Copy link
Contributor

@greenEkatherine greenEkatherine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add copyright, otherwise LGTM. Thank you for the contribution!

@jerry-shao
Copy link
Contributor Author

Please add copyright, otherwise LGTM. Thank you for the contribution!

Comments addressed, please review it again.

Thanks :D

@greenEkatherine
Copy link
Contributor

Please add copyright, otherwise LGTM. Thank you for the contribution!

Comments addressed, please review it again.

Thanks :D

Approved, thank you for the quick response

@greenEkatherine greenEkatherine merged commit ea42ae5 into microsoft:main Feb 9, 2022
@greenEkatherine greenEkatherine linked an issue Feb 9, 2022 that may be closed by this pull request
@greenEkatherine greenEkatherine added this to the YARP 1.1.0 milestone Feb 9, 2022
@MihaZupan MihaZupan modified the milestones: YARP 1.1.0, YARP 1.1.0-RC1 Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add RequestTransformContext.Query.Collection Case Insensitivity
4 participants