Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs on route metadata #2120

Merged
merged 1 commit into from
May 3, 2023
Merged

Conversation

jmezach
Copy link
Contributor

@jmezach jmezach commented May 3, 2023

I recently tried using the Kubernetes Ingress controller pieces from this repository. While trying out some things I noticed that the doc wasn't correct on how metadata should be configured using annotations on the Ingress. If I did it the way the docs said I got the following error:

warn: Yarp.Kubernetes.Controller.Services.Reconciler[0]
      Uncaught exception occured while reconciling ingress default/minimal-ingress
      (Line: 1, Col: 1, Idx: 0) - (Line: 1, Col: 1, Idx: 0): Expected 'MappingStart', got 'SequenceStart' (at Line: 1, Col: 1, Idx: 0).

After removing the dashes from the annotation it worked correctly.

Signed-off-by: Jonathan Mezach <jonathan.mezach@rr-wfm.com>
Copy link
Member

@MihaZupan MihaZupan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@MihaZupan MihaZupan merged commit 35ea0d3 into microsoft:main May 3, 2023
6 checks passed
@jmezach jmezach deleted the feature/doc-fix branch May 4, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants