Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed streaming flag to empty string when logging no gRPC request #2200

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Changed streaming flag to empty string when logging no gRPC request #2200

merged 1 commit into from
Jul 24, 2023

Conversation

marekott
Copy link
Contributor

As agreed in issue I've changed no-streaming flag to empty string when logging request that is not an gRPC request.

@marekott marekott mentioned this pull request Jul 24, 2023
Closed
@Tratcher Tratcher added this to the YARP 2.x milestone Jul 24, 2023
@Tratcher Tratcher merged commit 87511f2 into microsoft:main Jul 24, 2023
6 checks passed
@Tratcher
Copy link
Member

Thanks

@marekott
Copy link
Contributor Author

No problem

@marekott marekott deleted the issues-2194 branch July 25, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tratcher Tratcher Tratcher approved these changes

@MihaZupan MihaZupan Awaiting requested review from MihaZupan MihaZupan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
YARP 2.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marekott @Tratcher