Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for external names to Kubernetes Controller #2231

Conversation

HappyCodeSloth
Copy link
Contributor

@HappyCodeSloth HappyCodeSloth commented Aug 29, 2023

Closes #2230

@HappyCodeSloth
Copy link
Contributor Author

Issue

@HappyCodeSloth
Copy link
Contributor Author

@microsoft-github-policy-service agree company="AVEVA"

@HappyCodeSloth HappyCodeSloth force-pushed the kubernetes-controller-external-name-service branch from e562c78 to e87be41 Compare September 1, 2023 09:55
Copy link
Member

@MihaZupan MihaZupan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

src/Kubernetes.Controller/Converters/YarpParser.cs Outdated Show resolved Hide resolved
test/Kubernetes.Tests/Yarp.Kubernetes.Tests.csproj Outdated Show resolved Hide resolved
HappyCodeSloth and others added 2 commits September 4, 2023 16:38
Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
@MihaZupan MihaZupan merged commit 47f1e7c into microsoft:main Sep 4, 2023
6 checks passed
@MihaZupan MihaZupan added this to the YARP 2.x milestone Oct 3, 2023
@HappyCodeSloth HappyCodeSloth deleted the kubernetes-controller-external-name-service branch November 24, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kubernetes Controller Support External names
2 participants