Drop .NET 7.0 TFM #2498
Drop .NET 7.0 TFM #2498
Conversation
| <OutputType>Library</OutputType> | ||
| <RootNamespace>Yarp.ReverseProxy</RootNamespace> | ||
| <AllowUnsafeBlocks>true</AllowUnsafeBlocks> | ||
| <Nullable>enable</Nullable> | ||
| <IsAotCompatible>true</IsAotCompatible> | ||
| <IsAotCompatible Condition="'$(TargetFramework)' != 'net6.0'">true</IsAotCompatible> |
There was a problem hiding this comment.
I'm not sure why the condition is needed here now, but opened dotnet/sdk#40870 for it
| @@ -513,16 +513,6 @@ private void FixupUpgradeRequestHeaders(HttpContext context, HttpRequestMessage | |||
| { | |||
| // 5.0 servers provide a definitive answer for us. | |||
| hasBody = canHaveBodyFeature.CanHaveBody; | |||
|
|
|||
| #if NET7_0 | |||
| // TODO: Kestrel 7.0 bug only, hasBody shouldn't be true for ExtendedConnect. | |||
There was a problem hiding this comment.
This is a good reason not to remove the TFM, and why doing so is a breaking change, it's re-introducing a known compat bug.
There was a problem hiding this comment.
I think this part would be unreachable on 6.0 anyway, as the request would blow up earlier here
due to CONNECT not being supported.
|
Triage: We'll keep it for now as it isn't costing us much to keep around. If we hit any issues (build / compliance / etc.), we'll drop it. Warning If you're running YARP on .NET 7: don't. The scenario is no longer supported. |
No description provided.