Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Multiple Hosts for a Route #297

Merged
merged 1 commit into from Jul 6, 2020
Merged

Support Multiple Hosts for a Route #297

merged 1 commit into from Jul 6, 2020

Conversation

Kahbazi
Copy link
Collaborator

@Kahbazi Kahbazi commented Jul 3, 2020

Fixes #206

@Tratcher Tratcher self-assigned this Jul 4, 2020
Tratcher
Tratcher reviewed Jul 4, 2020
View reviewed changes
Copy link
Member

@Tratcher Tratcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The empty case needs some cleanup and test, but otherwise this looks good.

docs/docfx/articles/getting_started.md Outdated Show resolved Hide resolved
src/ReverseProxy/Service/DynamicEndpoints/RuntimeRouteBuilder.cs Outdated Show resolved Hide resolved
src/ReverseProxy/Service/Config/RuleParsing/RouteValidator.cs Outdated Show resolved Hide resolved
src/ReverseProxy/Service/Config/RuleParsing/RouteValidator.cs Outdated Show resolved Hide resolved
src/ReverseProxy/Service/Config/RuleParsing/RouteValidator.cs Outdated Show resolved Hide resolved
@Kahbazi Kahbazi force-pushed the kahbazi/AllowMultipleHost branch from b802607 to db63da7 Compare July 6, 2020 12:59
@Kahbazi
Copy link
Collaborator Author

Kahbazi commented Jul 6, 2020

@Tratcher Any Idea why the build is failing? It builds successfully on my machine. I can't figure out the reason. The error is 'ParsedRoute' does not contain a definition for 'Host' .

@Tratcher
Copy link
Member

Tratcher commented Jul 6, 2020

It's merging with the CORS changes before building. You need to rebase.

@Kahbazi Kahbazi force-pushed the kahbazi/AllowMultipleHost branch from db63da7 to dc59329 Compare July 6, 2020 16:11
@Tratcher Tratcher added this to the 1.0.0-preview3 milestone Jul 6, 2020
@Tratcher Tratcher merged commit 3e84b85 into microsoft:master Jul 6, 2020
@Tratcher
Copy link
Member

Tratcher commented Jul 6, 2020

Thanks

@Kahbazi Kahbazi deleted the kahbazi/AllowMultipleHost branch July 6, 2020 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tratcher Tratcher Tratcher approved these changes

@alnikola alnikola Awaiting requested review from alnikola

@halter73 halter73 Awaiting requested review from halter73

Assignees

@Tratcher Tratcher

Labels
Breaking-Change
Projects
None yet
Milestone
1.0.0-preview3
Development

Successfully merging this pull request may close these issues.

Support Multiple Hosts for a Route
2 participants
@Kahbazi @Tratcher