Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git add --renormalize . #35

Merged
merged 1 commit into from
Apr 1, 2020
Merged

git add --renormalize . #35

merged 1 commit into from
Apr 1, 2020

Conversation

halter73
Copy link
Member

@halter73 halter73 commented Apr 1, 2020

This enforces the .gitattributes line ending rules on files added before .gitattributes.

Copy link
Contributor

@analogrelay analogrelay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ALL THE CHURN!

@halter73
Copy link
Member Author

halter73 commented Apr 1, 2020

Seems to be a flaky test.
ProxyAsync_UpgradableRequest_Works

Error message
Expected string to be \n"request content" with a length of 15, but \n"" has a length of 0, differs near "" (index 0).


Stack trace
   at FluentAssertions.Execution.XUnit2TestFramework.Throw(String message)
   at FluentAssertions.Execution.TestFrameworkProvider.Throw(String message)
   at FluentAssertions.Execution.DefaultAssertionStrategy.HandleFailure(String message)
   at FluentAssertions.Execution.AssertionScope.FailWith(Func`1 failReasonFunc)
   at FluentAssertions.Primitives.StringEqualityValidator.ValidateAgainstLengthDifferences()
   at FluentAssertions.Primitives.StringValidator.Validate()
   at FluentAssertions.Primitives.StringAssertions.Be(String expected, String because, Object[] becauseArgs)
   at Microsoft.ReverseProxy.Core.Service.Proxy.Tests.HttpProxyTests.ProxyAsync_UpgradableRequest_Works() in /_/test/ReverseProxy.Core.Tests/Service/Proxy/HttpProxyTests.cs:line 176
--- End of stack trace from previous loc

#34

@halter73 halter73 merged commit 619c898 into master Apr 1, 2020
@halter73 halter73 deleted the halter73/renormalize branch April 1, 2020 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants