Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change routes from array to object #900

Merged
merged 3 commits into from
Apr 8, 2021
Merged

Change routes from array to object #900

merged 3 commits into from
Apr 8, 2021

Conversation

Kahbazi
Copy link
Collaborator

@Kahbazi Kahbazi commented Apr 8, 2021

Fixes #279

@Tratcher Tratcher self-assigned this Apr 8, 2021
Tratcher
Tratcher reviewed Apr 8, 2021
View reviewed changes
Copy link
Member

@Tratcher Tratcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the docs and samples too.

A few more docs need updating:
authn-authz.md
getting_started.md
transforms.md

samples/BasicYarpSample/appsettings.json Show resolved Hide resolved
src/ReverseProxy/Configuration/ConfigurationConfigProvider.cs Show resolved Hide resolved
docs/docfx/articles/configproviders.md Show resolved Hide resolved
@Tratcher Tratcher added this to the YARP 1.0.0-preview11 milestone Apr 8, 2021
@Tratcher Tratcher merged commit 344d968 into microsoft:main Apr 8, 2021
@Tratcher
Copy link
Member

Tratcher commented Apr 8, 2021

Thanks again!

@Kahbazi Kahbazi deleted the kahbazi/DictionaryRoutes branch April 8, 2021 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tratcher Tratcher Tratcher approved these changes

@alnikola alnikola Awaiting requested review from alnikola

@MihaZupan MihaZupan Awaiting requested review from MihaZupan MihaZupan is a code owner

Assignees

@Tratcher Tratcher

Labels
Breaking-Change
Projects
None yet
Milestone
YARP 1.0.0-preview11
Development

Successfully merging this pull request may close these issues.

Consistency in Configuration : Object Structures vs Arrays
2 participants
@Kahbazi @Tratcher