Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content Model: creating a DOM tree using selection marker results in blank window and/or throws an error. #2505

Closed
gm-al opened this issue Mar 13, 2024 · 4 comments · Fixed by #2545

Comments

@gm-al
Copy link
Contributor

gm-al commented Mar 13, 2024

Describe the bug
The selection marker has a few issues when trying to create a DOM tree using the selection marker, inputting a value in any of the style inputs results in a blank window or throws onUpdate is not a function.

To Reproduce
Steps to reproduce the behavior:

  1. Open roosterjs dome site. and click on the side pane.
  2. Click on the content model, and hover over the document word to see "the search icon" and click on it.
  3. Similarly, hover over the selection marker to see the option and click on format.

-> Throws onUpdate is not a function: 4. Input a value in any of these fields Font size, Font family, or Bold.
-> Window goes blank -> 4. Input a value in any of these fields Text color, or Back color.

Expected behavior
To update a value correctly.

Current behavior
Throws an error, and/or goes blank

Screenshots
Throws, onUpdate is not a function.
isajdoiasjdoiasjdoiasjd

The window goes blank.
doiwndoiuand

@JiuqingSong
Copy link
Contributor

I can't repro.

Do you mean just hover on the icon, no other operations? I tried but t here isn't any error to me
1

@gm-al
Copy link
Contributor Author

gm-al commented Mar 13, 2024

when you hover over SelectionMarker and the options pop up, next to the search icon click on the format icon

Screenshot 2024-03-14 011516

For onUpdate is not a function error, try inputting a value in any one of these fields, and check the dev console for the error:

Screenshot 2024-03-14 011758

@gm-al
Copy link
Contributor Author

gm-al commented Mar 13, 2024

Try inputting a value here and watch the window of the app go blank/white:

Screenshot 2024-03-14 012112

@JiuqingSong
Copy link
Contributor

I see. Now I can repro.

The demo site is just a demo (or a debugging tool), but not part of production. I'll take a look when I have got some time. You can also submit a fix if you want. Thanks.

JiuqingSong added a commit that referenced this issue Mar 28, 2024
JiuqingSong added a commit that referenced this issue Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants