Migrated KotlinSynthetics to ViewBinding

[thedroiddiv]

Purpose / Description

Migration to ViewBindings

Fixes

Fixes #4

How Has This Been Tested?

Tested on Pixel 4a API 30 and Realme 6i API 30

Learning (optional, can help others)

https://developer.android.com/topic/libraries/view-binding/migration

Checklist

Please, go through these checks before submitting the PR.

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[anuragshukla06]

I think we have KotlineSynthetics in other Fragments as well :( Are you planning to raise seperate PRs for them?

[thedroiddiv]

Yeah I was thinking of doing it a bit by bit. It would be easy to review rather than ten-twelve classes all at once. More chances of getting something wrong unnoticed.

[thedroiddiv]

And this is why I wanted the #3 to be merged first 🥹

[anuragshukla06]

Yeah I was thinking of doing it a bit by bit. It would be easy to review rather than ten-twelve classes all at once. More chances of getting something wrong unnoticed.

Sure, if you think there are not many changes, you can do it at once as well. As a sanity check after we have fully migrated, remove the dependency for KotlinSynthetics

[thedroiddiv]

making commit fragment by fragment, can be merged all at once.

[thedroiddiv]

@anuragshukla06 since I din't had tasks for all scenario, haven been able to test all of the fragments. Once tested, will mark it ready. Meanwhile if you want to review each commit could parallely do as well.

[thedroiddiv]

All the commits are independent, so if one commit it changed it won't cause any conflict to other ones. So that's a good part.

[thedroiddiv]

@anuragshukla06 these five commits are checked, can be merged.

[thedroiddiv]

These three also done. Seven fragments migrated and checked. Six more remaining.

[thedroiddiv]

@anuragshukla06 this line is throwing ArrayIndexOutOfBounds because colors is static array with size 4 but label may have different lengths.

Anyhow, I don't understand label here??

[anuragshukla06]

labels come from the server. At the time, we dont receive colors corresponding to labels from the server and the labels are not supposed to be more than 4.
Label in this image annotation task denotes one type of classification that the user can mark. We differentiate labels from each other visually by the colors for the user. There exists a one-to-one mapping from label to color

[anuragshukla06]

Did you remove the gradle dependency on Kotlin synthetic? Rest looks good to me

[thedroiddiv]

@anuragshukla06 finally done with the migration, removed the dependency as well. Next on list is gradle upgrade.