Merge pull request #4747 from iclanton/stricter-types

Enable some stricter compiler options and eliminate remaining const enums.

apps/api-documenter/src/documenters/YamlDocumenter.ts

@@ -73,7 +73,7 @@ interface IYamlReferences {
   uidTypeReferenceCounters: Map<string, number>;
 }
 
-const enum FlattenMode {
+enum FlattenMode {
   /** Include entries for nested namespaces and non-namespace children. */
   NestedNamespacesAndChildren,
   /** Include entries for nested namespaces only. */

apps/api-documenter/src/index.ts

@@ -9,12 +9,12 @@
  * @packageDocumentation
  */
 
-export { IFeatureDefinition, IApiDocumenterPluginManifest } from './plugin/IApiDocumenterPluginManifest';
+export type { IFeatureDefinition, IApiDocumenterPluginManifest } from './plugin/IApiDocumenterPluginManifest';
 export { MarkdownDocumenterAccessor } from './plugin/MarkdownDocumenterAccessor';
 export {
   MarkdownDocumenterFeatureContext,
-  IMarkdownDocumenterFeatureOnBeforeWritePageArgs,
-  IMarkdownDocumenterFeatureOnFinishedArgs,
+  type IMarkdownDocumenterFeatureOnBeforeWritePageArgs,
+  type IMarkdownDocumenterFeatureOnFinishedArgs,
   MarkdownDocumenterFeature
 } from './plugin/MarkdownDocumenterFeature';
 export { PluginFeature, PluginFeatureContext, PluginFeatureInitialization } from './plugin/PluginFeature';

apps/api-documenter/src/nodes/CustomDocNodeKind.ts

@@ -12,7 +12,7 @@ import { DocTableRow } from './DocTableRow';
 /**
  * Identifies custom subclasses of {@link DocNode}.
  */
-export const enum CustomDocNodeKind {
+export enum CustomDocNodeKind {
   EmphasisSpan = 'EmphasisSpan',
   Heading = 'Heading',
   NoteBox = 'NoteBox',

apps/api-extractor/src/index.ts

@@ -11,28 +11,28 @@
 
 export { ConsoleMessageId } from './api/ConsoleMessageId';
 
-export { CompilerState, ICompilerStateCreateOptions } from './api/CompilerState';
+export { CompilerState, type ICompilerStateCreateOptions } from './api/CompilerState';
 
-export { Extractor, IExtractorInvokeOptions, ExtractorResult } from './api/Extractor';
+export { Extractor, type IExtractorInvokeOptions, ExtractorResult } from './api/Extractor';
 
 export {
-  IExtractorConfigApiReport,
-  IExtractorConfigPrepareOptions,
-  IExtractorConfigLoadForFolderOptions,
+  type IExtractorConfigApiReport,
+  type IExtractorConfigPrepareOptions,
+  type IExtractorConfigLoadForFolderOptions,
   ExtractorConfig
 } from './api/ExtractorConfig';
 
 export { ExtractorLogLevel } from './api/ExtractorLogLevel';
 
 export {
   ExtractorMessage,
-  IExtractorMessageProperties,
+  type IExtractorMessageProperties,
   ExtractorMessageCategory
 } from './api/ExtractorMessage';
 
 export { ExtractorMessageId } from './api/ExtractorMessageId';
 
-export {
+export type {
   ApiReportVariant,
   IConfigCompiler,
   IConfigApiReport,

apps/api-extractor/tsconfig.json

@@ -2,6 +2,7 @@
   "extends": "./node_modules/@rushstack/heft-node-rig/profiles/default/tsconfig-base.json",
 
   "compilerOptions": {
+    "isolatedModules": true,
     "types": ["heft-jest", "node"],
     "resolveJsonModule": true
   }

apps/heft/tsconfig.json

@@ -2,6 +2,7 @@
   "extends": "./node_modules/@rushstack/heft-node-rig/profiles/default/tsconfig-base.json",
 
   "compilerOptions": {
+    "isolatedModules": true,
     "types": ["heft-jest", "node"],
     "lib": ["ES2020"],
     "resolveJsonModule": true

apps/rundown/src/LauncherTypes.ts

@@ -1,7 +1,7 @@
 // Copyright (c) Microsoft Corporation. All rights reserved. Licensed under the MIT license.
 // See LICENSE in the project root for license information.
 
-export const enum LauncherAction {
+export enum LauncherAction {
   Snapshot = 'snapshot',
   Inspect = 'inspect'
 }

build-tests-samples/heft-node-rig-tutorial/tsconfig.json

@@ -1,6 +1,7 @@
 {
   "extends": "./node_modules/@rushstack/heft-node-rig/profiles/default/tsconfig-base.json",
   "compilerOptions": {
+    "isolatedModules": true,
     "types": ["heft-jest", "node"]
   }
 }

build-tests/api-extractor-scenarios/src/docReferencesAlias/index.ts

@@ -1,5 +1,5 @@
 // Copyright (c) Microsoft Corporation. All rights reserved. Licensed under the MIT license.
 // See LICENSE in the project root for license information.
 
-export { default as renamed_Options } from './Options';
+export type { default as renamed_Options } from './Options';
 export { default as Item } from './Item';

build-tests/api-extractor-scenarios/src/docReferencesNamespaceAlias/renamed/sub/index.ts

@@ -1,4 +1,4 @@
 // Copyright (c) Microsoft Corporation. All rights reserved. Licensed under the MIT license.
 // See LICENSE in the project root for license information.
 
-export { default as SubOptions } from './SubOptions';
+export type { default as SubOptions } from './SubOptions';

build-tests/api-extractor-scenarios/tsconfig.json

@@ -2,7 +2,10 @@
   "extends": "./node_modules/local-node-rig/profiles/default/tsconfig-base.json",
   "compilerOptions": {
     "strictPropertyInitialization": false,
-    "noImplicitAny": false
+    "noImplicitAny": false,
+    // Intentionally turn this off for this project to test a combination of `export` and `export type`
+    // with type-only exports
+    "isolatedModules": false
   },
   "include": ["src/**/*.ts", "typings/tsd.d.ts"]
 }

common/changes/@microsoft/api-documenter/stricter-types_2024-05-29-06-10.json

@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@microsoft/api-documenter",
+      "comment": "Include missing `type` modifiers on type-only exports.",
+      "type": "patch"
+    }
+  ],
+  "packageName": "@microsoft/api-documenter"
+}

common/changes/@microsoft/api-extractor-model/stricter-types_2024-05-29-06-10.json

@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@microsoft/api-extractor-model",
+      "comment": "Include missing `type` modifiers on type-only exports.",
+      "type": "patch"
+    }
+  ],
+  "packageName": "@microsoft/api-extractor-model"
+}

common/changes/@microsoft/api-extractor/stricter-types_2024-05-29-06-10.json

@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@microsoft/api-extractor",
+      "comment": "Include missing `type` modifiers on type-only exports.",
+      "type": "patch"
+    }
+  ],
+  "packageName": "@microsoft/api-extractor"
+}

common/changes/@microsoft/rush/stricter-types_2024-05-29-06-10.json

@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@microsoft/rush",
+      "comment": "Include missing `type` modifiers on type-only exports.",
+      "type": "none"
+    }
+  ],
+  "packageName": "@microsoft/rush"
+}

common/changes/@rushstack/debug-certificate-manager/stricter-types_2024-05-29-06-10.json

@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@rushstack/debug-certificate-manager",
+      "comment": "Include missing `type` modifiers on type-only exports.",
+      "type": "patch"
+    }
+  ],
+  "packageName": "@rushstack/debug-certificate-manager"
+}

common/changes/@rushstack/eslint-patch/stricter-types_2024-05-29-06-10.json

@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@rushstack/eslint-patch",
+      "comment": "",
+      "type": "none"
+    }
+  ],
+  "packageName": "@rushstack/eslint-patch"
+}

common/changes/@rushstack/eslint-plugin-packlets/stricter-types_2024-05-29-06-10.json

@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@rushstack/eslint-plugin-packlets",
+      "comment": "",
+      "type": "none"
+    }
+  ],
+  "packageName": "@rushstack/eslint-plugin-packlets"
+}

common/changes/@rushstack/eslint-plugin-security/stricter-types_2024-05-29-06-10.json

@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@rushstack/eslint-plugin-security",
+      "comment": "",
+      "type": "none"
+    }
+  ],
+  "packageName": "@rushstack/eslint-plugin-security"
+}

common/changes/@rushstack/eslint-plugin/stricter-types_2024-05-29-06-10.json

@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@rushstack/eslint-plugin",
+      "comment": "",
+      "type": "none"
+    }
+  ],
+  "packageName": "@rushstack/eslint-plugin"
+}

common/changes/@rushstack/heft-api-extractor-plugin/stricter-types_2024-05-29-06-10.json

@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@rushstack/heft-api-extractor-plugin",
+      "comment": "",
+      "type": "none"
+    }
+  ],
+  "packageName": "@rushstack/heft-api-extractor-plugin"
+}

common/changes/@rushstack/heft-config-file/stricter-types_2024-05-29-06-10.json

@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@rushstack/heft-config-file",
+      "comment": "Include missing `type` modifiers on type-only exports.",
+      "type": "patch"
+    }
+  ],
+  "packageName": "@rushstack/heft-config-file"
+}

common/changes/@rushstack/heft-jest-plugin/stricter-types_2024-05-29-06-10.json

@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@rushstack/heft-jest-plugin",
+      "comment": "",
+      "type": "none"
+    }
+  ],
+  "packageName": "@rushstack/heft-jest-plugin"
+}

common/changes/@rushstack/heft-lint-plugin/stricter-types_2024-05-29-06-10.json

@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@rushstack/heft-lint-plugin",
+      "comment": "",
+      "type": "none"
+    }
+  ],
+  "packageName": "@rushstack/heft-lint-plugin"
+}

common/changes/@rushstack/heft-typescript-plugin/stricter-types_2024-05-29-06-10.json

@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@rushstack/heft-typescript-plugin",
+      "comment": "",
+      "type": "none"
+    }
+  ],
+  "packageName": "@rushstack/heft-typescript-plugin"
+}

common/changes/@rushstack/heft/stricter-types_2024-05-29-06-10.json

@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@rushstack/heft",
+      "comment": "",
+      "type": "none"
+    }
+  ],
+  "packageName": "@rushstack/heft"
+}

common/changes/@rushstack/localization-utilities/stricter-types_2024-05-29-06-10.json

@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@rushstack/localization-utilities",
+      "comment": "Include missing `type` modifiers on type-only exports.",
+      "type": "patch"
+    }
+  ],
+  "packageName": "@rushstack/localization-utilities"
+}

common/changes/@rushstack/node-core-library/stricter-types_2024-05-29-06-10.json

@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@rushstack/node-core-library",
+      "comment": "Include missing `type` modifiers on type-only exports.",
+      "type": "patch"
+    }
+  ],
+  "packageName": "@rushstack/node-core-library"
+}

common/changes/@rushstack/operation-graph/stricter-types_2024-05-29-06-10.json

@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@rushstack/operation-graph",
+      "comment": "",
+      "type": "none"
+    }
+  ],
+  "packageName": "@rushstack/operation-graph"
+}

common/changes/@rushstack/package-deps-hash/stricter-types_2024-05-29-06-10.json

@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@rushstack/package-deps-hash",
+      "comment": "Include missing `type` modifiers on type-only exports.",
+      "type": "patch"
+    }
+  ],
+  "packageName": "@rushstack/package-deps-hash"
+}

common/changes/@rushstack/rig-package/stricter-types_2024-05-29-06-10.json

@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@rushstack/rig-package",
+      "comment": "",
+      "type": "none"
+    }
+  ],
+  "packageName": "@rushstack/rig-package"
+}

common/changes/@rushstack/rundown/stricter-types_2024-05-29-06-10.json

@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@rushstack/rundown",
+      "comment": "",
+      "type": "none"
+    }
+  ],
+  "packageName": "@rushstack/rundown"
+}

common/changes/@rushstack/set-webpack-public-path-plugin/stricter-types_2024-05-29-06-10.json

@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@rushstack/set-webpack-public-path-plugin",
+      "comment": "Include missing `type` modifiers on type-only exports.",
+      "type": "patch"
+    }
+  ],
+  "packageName": "@rushstack/set-webpack-public-path-plugin"
+}