Turn on some stricter compiler options.

microsoft · May 29, 2024 · 5a185aa · 5a185aa
1 parent 0dab699
commit 5a185aa
Show file tree

Hide file tree

Showing 24 changed files with 27 additions and 2 deletions.
diff --git a/apps/api-extractor/tsconfig.json b/apps/api-extractor/tsconfig.json
@@ -2,6 +2,7 @@
   "extends": "./node_modules/@rushstack/heft-node-rig/profiles/default/tsconfig-base.json",
 
   "compilerOptions": {
+    "isolatedModules": true,
     "types": ["heft-jest", "node"],
     "resolveJsonModule": true
   }

diff --git a/apps/heft/tsconfig.json b/apps/heft/tsconfig.json
@@ -2,6 +2,7 @@
   "extends": "./node_modules/@rushstack/heft-node-rig/profiles/default/tsconfig-base.json",
 
   "compilerOptions": {
+    "isolatedModules": true,
     "types": ["heft-jest", "node"],
     "lib": ["ES2020"],
     "resolveJsonModule": true

diff --git a/build-tests-samples/heft-node-rig-tutorial/tsconfig.json b/build-tests-samples/heft-node-rig-tutorial/tsconfig.json
@@ -1,6 +1,7 @@
 {
   "extends": "./node_modules/@rushstack/heft-node-rig/profiles/default/tsconfig-base.json",
   "compilerOptions": {
+    "isolatedModules": true,
     "types": ["heft-jest", "node"]
   }
 }
diff --git a/build-tests/api-extractor-scenarios/tsconfig.json b/build-tests/api-extractor-scenarios/tsconfig.json
@@ -2,7 +2,10 @@
   "extends": "./node_modules/local-node-rig/profiles/default/tsconfig-base.json",
   "compilerOptions": {
     "strictPropertyInitialization": false,
-    "noImplicitAny": false
+    "noImplicitAny": false,
+    // Intentionally turn this off for this project to test a combination of `export` and `export type`
+    // with type-only exports
+    "isolatedModules": false
   },
   "include": ["src/**/*.ts", "typings/tsd.d.ts"]
 }
diff --git a/eslint/eslint-patch/tsconfig.json b/eslint/eslint-patch/tsconfig.json
@@ -1,6 +1,7 @@
 {
   "extends": "./node_modules/@rushstack/heft-node-rig/profiles/default/tsconfig-base.json",
   "compilerOptions": {
+    "isolatedModules": true,
     "types": ["node"],
     "resolveJsonModule": true
   }

diff --git a/eslint/eslint-plugin-packlets/tsconfig.json b/eslint/eslint-plugin-packlets/tsconfig.json
@@ -2,6 +2,7 @@
   "extends": "./node_modules/@rushstack/heft-node-rig/profiles/default/tsconfig-base.json",
 
   "compilerOptions": {
+    "isolatedModules": true,
     "module": "Node16",
     "types": ["heft-jest", "node"]
   }

diff --git a/eslint/eslint-plugin-security/tsconfig.json b/eslint/eslint-plugin-security/tsconfig.json
@@ -2,6 +2,7 @@
   "extends": "./node_modules/@rushstack/heft-node-rig/profiles/default/tsconfig-base.json",
 
   "compilerOptions": {
+    "isolatedModules": true,
     "module": "Node16",
     "types": ["heft-jest", "node"]
   }

diff --git a/eslint/eslint-plugin/tsconfig.json b/eslint/eslint-plugin/tsconfig.json
@@ -2,6 +2,7 @@
   "extends": "./node_modules/@rushstack/heft-node-rig/profiles/default/tsconfig-base.json",
 
   "compilerOptions": {
+    "isolatedModules": true,
     "module": "Node16",
     "types": ["heft-jest", "node"]
   }

diff --git a/eslint/local-eslint-config/profile/_common.js b/eslint/local-eslint-config/profile/_common.js
@@ -85,7 +85,7 @@ function buildRules(profile) {
           radix: 'error',
 
           // Rationale: Including the `type` annotation in the import statement for imports
-          // only used as types prevents the import from being omitted in the compiled output.
+          // only used as types prevents the import from being emitted in the compiled output.
           '@typescript-eslint/consistent-type-imports': [
             'warn',
             { prefer: 'type-imports', disallowTypeAnnotations: false, fixStyle: 'inline-type-imports' }

diff --git a/heft-plugins/heft-api-extractor-plugin/tsconfig.json b/heft-plugins/heft-api-extractor-plugin/tsconfig.json
@@ -2,6 +2,7 @@
   "extends": "./node_modules/@rushstack/heft-node-rig/profiles/default/tsconfig-base.json",
 
   "compilerOptions": {
+    "isolatedModules": true,
     "types": ["node"],
     "resolveJsonModule": true
   }

diff --git a/heft-plugins/heft-jest-plugin/tsconfig.json b/heft-plugins/heft-jest-plugin/tsconfig.json
@@ -2,6 +2,7 @@
   "extends": "./node_modules/@rushstack/heft-node-rig/profiles/default/tsconfig-base.json",
 
   "compilerOptions": {
+    "isolatedModules": true,
     "types": ["node", "heft-jest"],
     "resolveJsonModule": true
   }

diff --git a/heft-plugins/heft-lint-plugin/tsconfig.json b/heft-plugins/heft-lint-plugin/tsconfig.json
@@ -2,6 +2,7 @@
   "extends": "./node_modules/@rushstack/heft-node-rig/profiles/default/tsconfig-base.json",
 
   "compilerOptions": {
+    "isolatedModules": true,
     "types": ["node"]
   }
 }
diff --git a/heft-plugins/heft-typescript-plugin/tsconfig.json b/heft-plugins/heft-typescript-plugin/tsconfig.json
@@ -2,6 +2,7 @@
   "extends": "./node_modules/@rushstack/heft-node-rig/profiles/default/tsconfig-base.json",
 
   "compilerOptions": {
+    "isolatedModules": true,
     "types": ["node"],
     "lib": ["ES2019"],
     "resolveJsonModule": true

diff --git a/libraries/api-extractor-model/tsconfig.json b/libraries/api-extractor-model/tsconfig.json
@@ -2,6 +2,7 @@
   "extends": "./node_modules/@rushstack/heft-node-rig/profiles/default/tsconfig-base.json",
 
   "compilerOptions": {
+    "isolatedModules": true,
     "types": ["heft-jest", "node"]
   }
 }
diff --git a/libraries/heft-config-file/tsconfig.json b/libraries/heft-config-file/tsconfig.json
@@ -2,6 +2,7 @@
   "extends": "./node_modules/@rushstack/heft-node-rig/profiles/default/tsconfig-base.json",
 
   "compilerOptions": {
+    "isolatedModules": true,
     "types": ["heft-jest", "node"]
   }
 }
diff --git a/libraries/node-core-library/tsconfig.json b/libraries/node-core-library/tsconfig.json
@@ -2,6 +2,7 @@
   "extends": "./node_modules/@rushstack/heft-node-rig/profiles/default/tsconfig-base.json",
 
   "compilerOptions": {
+    "isolatedModules": true,
     "types": ["heft-jest", "node"]
   }
 }
diff --git a/libraries/operation-graph/tsconfig.json b/libraries/operation-graph/tsconfig.json
@@ -2,6 +2,7 @@
   "extends": "./node_modules/@rushstack/heft-node-rig/profiles/default/tsconfig-base.json",
 
   "compilerOptions": {
+    "isolatedModules": true,
     "allowSyntheticDefaultImports": true,
     "target": "ES2020",
     "lib": ["ES2020"],

diff --git a/libraries/rig-package/tsconfig.json b/libraries/rig-package/tsconfig.json
@@ -2,6 +2,7 @@
   "extends": "./node_modules/@rushstack/heft-node-rig/profiles/default/tsconfig-base.json",
 
   "compilerOptions": {
+    "isolatedModules": true,
     "types": ["heft-jest", "node"]
   }
 }
diff --git a/libraries/terminal/tsconfig.json b/libraries/terminal/tsconfig.json
@@ -2,6 +2,7 @@
   "extends": "./node_modules/@rushstack/heft-node-rig/profiles/default/tsconfig-base.json",
 
   "compilerOptions": {
+    "isolatedModules": true,
     "types": ["heft-jest", "node"]
   }
 }
diff --git a/libraries/tree-pattern/tsconfig.json b/libraries/tree-pattern/tsconfig.json
@@ -2,6 +2,7 @@
   "extends": "./node_modules/@rushstack/heft-node-rig/profiles/default/tsconfig-base.json",
 
   "compilerOptions": {
+    "isolatedModules": true,
     "types": ["heft-jest"]
   }
 }
diff --git a/libraries/ts-command-line/tsconfig.json b/libraries/ts-command-line/tsconfig.json
@@ -2,6 +2,7 @@
   "extends": "./node_modules/@rushstack/heft-node-rig/profiles/default/tsconfig-base.json",
 
   "compilerOptions": {
+    "isolatedModules": true,
     "types": ["heft-jest", "node"]
   }
 }
diff --git a/rigs/local-node-rig/profiles/default/tsconfig-base.json b/rigs/local-node-rig/profiles/default/tsconfig-base.json
@@ -5,6 +5,7 @@
 
   "compilerOptions": {
     "resolveJsonModule": true,
+    "isolatedModules": true,
 
     "outDir": "../../../../lib",
     "rootDir": "../../../../src",

diff --git a/rigs/local-web-rig/profiles/app/tsconfig-base.json b/rigs/local-web-rig/profiles/app/tsconfig-base.json
@@ -5,6 +5,7 @@
 
   "compilerOptions": {
     "resolveJsonModule": true,
+    "isolatedModules": true,
 
     "target": "es2017",
     "lib": ["es2017", "scripthost", "es2015.collection", "es2015.promise", "es2015.iterable", "dom"],

diff --git a/rigs/local-web-rig/profiles/library/tsconfig-base.json b/rigs/local-web-rig/profiles/library/tsconfig-base.json
@@ -5,6 +5,7 @@
 
   "compilerOptions": {
     "resolveJsonModule": true,
+    "isolatedModules": true,
 
     "outDir": "../../../../lib",
     "rootDir": "../../../../src",