Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rush] "rush update" error when adding new project to rush.json #1418

Closed
1 of 2 tasks
ScottHysom opened this issue Jul 26, 2019 · 5 comments
Closed
1 of 2 tasks

[rush] "rush update" error when adding new project to rush.json #1418

ScottHysom opened this issue Jul 26, 2019 · 5 comments
Assignees

Comments

@ScottHysom
Copy link
Member

Is this a feature or a bug?

  • Feature
  • Bug

Please describe the actual behavior.
With rush version 5.10.3 and pnpm version 3.6.0, users can no longer add a new project to their rush.json and run rush update. Instead, rush update results in this error:

ERROR: Cannot get dependency key for temp project: @rush-temp/new-project

A simple repro can be found at https://github.com/ScottHysom/rush-issue-add-project. See the README.md for simple repro steps.

To work around this issue, a user must manually change the pnpm-lock.yaml and add the following line under the top dependencies key:

'@rush-temp/new-project': 'file:path-to-project/new-project.tgz'

What is the expected behavior?
rush update succeeds in updating the pnpm lock file without manual intervention.

If this is a bug, please provide the tool version, Node.js version, and OS.

  • Tool: rush
  • Tool Version: 5.10.3
  • pnpm Version: 3.6.0
  • Node Version: 10.14.1
    • Is this a LTS version? Yes
    • Have you tested on a LTS version? Yes
  • OS: Windows 10 version 1903
@iclanton
Copy link
Member

@sachinjoseph, this looks like a regression from one of your recent PNPM bugfixes. Can you take a look at this?

@sachinjoseph
Copy link
Member

Looking into it

sachinjoseph added a commit that referenced this issue Jul 26, 2019
@sachinjoseph
Copy link
Member

#1422

@sachinjoseph
Copy link
Member

@ScottHysom Can you verify with Rush 5.11.0?

@ScottHysom
Copy link
Member Author

I have confirmed this issue has been resolved with 5.11.0. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants