[Rush] detect the package root traversing bottom-to-root, not root-to-bottom

[Jabher]

Please prefix the issue title with the project name i.e. [rush], [api-extractor] etc.

Is this a feature or a bug?

• Feature
• Bug

Please describe the actual behavior.
Assuming I have a rush project with 2 packages, 1 in . (as long as I'm trying to resolve some pnpm&eslint issues by manual root creation of node_modules), second in ./packages/whatever,

when i type rush add -p %package_name% in ./packages/whatever directory,
dependency is added to package at ..

What is the expected behavior?
I expect rush to detect the package as close as possible and add dependency there, not to the topmost one.

If this is a bug, please provide the tool version, Node.js version, and OS.

• Tool: Rush
• Tool Version: 5.17.2
• Node Version: 12.14.0
  • Is this a LTS version? yes
  • Have you tested on a LTS version? yes
• OS: Mac OS X

also, PNPM 4.6.0 is used.

[iclanton]

I'm trying to understand your repo's layout. Can you provide a simple repro repo?

[Jabher]

stages to reproduce:

• clone https://github.com/Jabher/rush-bug-report-ref & run rush update
• go to directory b/c
• run rush add -p left-pad
  expected behavior: left-pad is added to b/c/package.json
  actual behavior: left-pad is added to <root>/package.json

[trusktr]

Looks like #1702 is a duplicate of this, with some more info there.