Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rush] Feature Request: Type to filter in upgrade-interactive #3788

Open
ethanrcohen opened this issue Nov 28, 2022 · 2 comments
Open

[rush] Feature Request: Type to filter in upgrade-interactive #3788

ethanrcohen opened this issue Nov 28, 2022 · 2 comments
Labels
effort: medium Needs a somewhat experienced developer help wanted If you're looking to contribute, this issue is a good place to start!
Projects

Comments

@ethanrcohen
Copy link

Summary

Using upgrade-interactive is a huge QOL improvement from our previous upgrade process! But it is a bit tedious to page up/down to find the relevant project in moderately sized monorepos. It would be awesome if one could just start typing the name of the package that they want to upgrade with the list of projects updating in response.

Standard questions

Please answer these questions to help us investigate your issue more quickly:

Question Answer
@microsoft/rush globally installed version? 5.74.0
rushVersion from rush.json? 5.83.3
useWorkspaces from rush.json? true
Operating system? Mac
Would you consider contributing a PR? Yes
Node.js version (node -v)? 16.13.0
@ethanrcohen
Copy link
Author

Took a quick look at the source code and saw that inquirer does not support this functionality without use of an addon like https://github.com/robin-rpr/inquirer-search-list. Would the team be interested in adding that dependency to support this use case?

@iclanton
Copy link
Member

iclanton commented Dec 5, 2022

This seems pretty similar to #3732, but for the dependency name instead of the project name (if I'm reading this correctly). The code that @TheLarkInn put together for that could probably be reused.

@iclanton iclanton added help wanted If you're looking to contribute, this issue is a good place to start! effort: medium Needs a somewhat experienced developer labels Dec 5, 2022
@iclanton iclanton added this to Low priority in Bug Triage Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: medium Needs a somewhat experienced developer help wanted If you're looking to contribute, this issue is a good place to start!
Projects
Status: Low priority
Bug Triage
  
Low priority
Development

No branches or pull requests

2 participants