[rush-lib] Add project filtering to upgrade-interactive ui #3732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheLarkInn
requested review from
iclanton,
octogonz,
apostolisms,
D4N14L and
patmill
as code owners
dmichon-msft
reviewed
Nov 4, 2022
dmichon-msft
reviewed
Nov 4, 2022
|
Ready for re-review/LIA. |
iclanton
reviewed
Nov 10, 2022
common/changes/@microsoft/rush/feature-ui-filter-prompt_2022-11-04-21-07.json
Outdated
Show resolved
Hide resolved
dmichon-msft
approved these changes
Nov 16, 2022
|
@dmichon-msft can you LIA those last changes |
TheLarkInn
force-pushed
the
feature/ui-filter-prompt
branch
from
dbb81cb
to
2ba295e
Compare
dmichon-msft
approved these changes
Nov 19, 2022
iclanton
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces project filtering feature as a part of the
upgrade-interactiveUI.Details
By default a user will now be able to type after running
upgrade-interactiveto filter from the list of projects in their monorepo.In addition the PR also expands the default list height/pageSize to 12 for the prompt so you can see more projects before infinite scrolling begins.
The PR also adds missing licenses and attribution links.
How it was tested