Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rush] "rush version" fails if the cwd is not the repository root #669

Closed
octogonz opened this issue May 31, 2018 · 1 comment
Closed

[rush] "rush version" fails if the cwd is not the repository root #669

octogonz opened this issue May 31, 2018 · 1 comment
Assignees
@sachinjoseph
Labels
bug Something isn't working as intended effort: easy Probably a quick fix. Want to contribute? :-) help wanted If you're looking to contribute, this issue is a good place to start!
Projects
Bug Triage

Comments

@octogonz
Copy link
Collaborator

octogonz commented May 31, 2018 •
edited

If I run this command from the repository root folder, it works fine:

rush version --bump --version-policy rush

But if I run it from a project subfolder, I get this error:

* EXECUTING: git add **/CHANGELOG.json

* EXECUTING: git add **/CHANGELOG.md
fatal: pathspec '**/CHANGELOG.md' did not match any files

ERROR: The command failed with exit code 128

Should be pretty easy to fix.
@octogonz octogonz added bug Something isn't working as intended help wanted If you're looking to contribute, this issue is a good place to start! effort: easy Probably a quick fix. Want to contribute? :-) labels Sep 14, 2018
@octogonz octogonz changed the title "rush version" fails if the cwd is not the repository root [rush] "rush version" fails if the cwd is not the repository root Sep 14, 2018
@halfnibble halfnibble assigned sachinjoseph and unassigned qz2017 Jun 21, 2019
@rakeshpatnaik rakeshpatnaik added this to High priority in Bug Triage Jul 3, 2019
@rakeshpatnaik rakeshpatnaik moved this from High priority to In Progress in Bug Triage Jul 3, 2019
sachinjoseph added a commit that referenced this issue Jul 12, 2019
@sachinjoseph
[rush] Fix for '"rush version" fails if the cwd is not the repository…
f228cd6 
… root #669'

For rush publish and rush version, change the path spec for git add to include everything from the root directory.
@sachinjoseph sachinjoseph mentioned this issue Jul 12, 2019
Merged
iclanton added a commit that referenced this issue Sep 4, 2019
@iclanton
Merge pull request #1380 from microsoft/sachinjoseph/fix669
d5c80cc 
[rush] For "rush publish" and "rush version", change the path spec for 'git add' to include everything from the root directory. This addresses #669.
@iclanton
Copy link
Member

iclanton commented Sep 4, 2019

The fix for this has been released in Rush 5.12.0

@iclanton iclanton closed this as completed Sep 4, 2019
Bug Triage automation moved this from In Progress to Closed Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sachinjoseph sachinjoseph

Labels
bug Something isn't working as intended effort: easy Probably a quick fix. Want to contribute? :-) help wanted If you're looking to contribute, this issue is a good place to start!
Projects
Bug Triage
Archived in project
Bug Triage
  
Closed
Milestone
No milestone
Development

No branches or pull requests
4 participants
@octogonz @qz2017 @iclanton @sachinjoseph