Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rush] Fix an issue where "rush setup" reported a TypeError when invoked from Git Bash #3219

Merged
merged 2 commits into from Feb 9, 2022
Merged

[rush] Fix an issue where "rush setup" reported a TypeError when invoked from Git Bash #3219

merged 2 commits into from Feb 9, 2022

Conversation

octogonz
Copy link
Collaborator

@octogonz octogonz commented Feb 9, 2022

Summary

Fixes #3217

How it was tested

  • I used Git Bash to reproduce the error from [rush] "rush setup" does not work on Windows when using Git bash #3217, and then confirmed that it is fixed when rush setup is invoked using the code from this PR branch
  • To test the case where the TTY is missing without Git Bash, I used Cmd.exe to invoke rush setup < empty-file
  • I tested each of the 3 workarounds from the error message text

CC @elliot-nelson

@octogonz octogonz mentioned this pull request Feb 9, 2022
Closed
@octogonz octogonz merged commit 3b8a675 into master Feb 9, 2022
@octogonz octogonz deleted the octogonz/rush-git-bash branch February 9, 2022 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iclanton iclanton iclanton approved these changes

@apostolisms apostolisms Awaiting requested review from apostolisms

@D4N14L D4N14L Awaiting requested review from D4N14L

@sachinjoseph sachinjoseph Awaiting requested review from sachinjoseph

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[rush] "rush setup" does not work on Windows when using Git bash
2 participants
@octogonz @iclanton