[heft-sass-plugin] Fix identification of SASS partials on Windows #3673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmichon-msft
changed the title
|
Strictly speaking, the issue is that the recent update assumed that input paths have been normalized to use |
iclanton
approved these changes
Oct 5, 2022
common/changes/@rushstack/heft-sass-plugin/atingmicrosoft-fix-scss-issues_2022-10-05-00-02.json
Outdated
Show resolved
Hide resolved
…scss-issues_2022-10-05-00-02.json
This was referenced Nov 28, 2023
This was referenced Mar 23, 2024
This was referenced May 13, 2024
This was referenced May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Current rushstack is causing sass files to load incorrectly in odsp-web. Sass files with title names starting with _ (ex. _Animation.scss) are being excluded because some scss files don't end in '/'. Need to revert to previous version.
Details
Solved problem by reverting the code that checks scss files to previous build.
How it was tested
Tested in odsp-web manually and then came here for fix.