Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api-extractor] Update API Extractor to support TypeScript 5.3.3 #4408

Merged
merged 9 commits into from Dec 19, 2023

Conversation

octogonz
Copy link
Collaborator

@octogonz octogonz commented Oct 24, 2023

Summary

Fixes #4404

Details

👉 This is a draft PR because TypeScript 5.3 has not shipped yet. We generally would not do an official API Extractor release that bundles a beta version of the TypeScript compiler.

How it was tested

Confirmed that the API Extractor tests pass.

@rvion
Copy link

rvion commented Nov 26, 2023

any way to help supporting more recent version of typescript for API Extractor ? not having as const nor proper branch refinments is really forcing more and more antipatterns in code to keep using api-extractor

@octogonz
Copy link
Collaborator Author

octogonz commented Dec 8, 2023

any way to help supporting more recent version of typescript for API Extractor ? not having as const nor proper branch refinments is really forcing more and more antipatterns in code to keep using api-extractor

Thanks for bumping this, @rvion!

Looks like Typescript 5.3.3 has already been released, so we can now proceed with merging this PR. I've converted it to non-draft.

@octogonz octogonz marked this pull request as ready for review December 8, 2023 17:44
apps/api-extractor/package.json Outdated Show resolved Hide resolved
apps/api-extractor/src/analyzer/TypeScriptInternals.ts Outdated Show resolved Hide resolved
common/config/rush/common-versions.json Outdated Show resolved Hide resolved
…s-5.3.0-beta

# Conflicts:
#	common/config/rush/pnpm-lock.yaml
#	common/config/rush/repo-state.json
@octogonz octogonz changed the title Update API Extractor to support TypeScript 5.3.0-beta Update API Extractor to support TypeScript 5.3.3 Dec 19, 2023
@octogonz octogonz merged commit 4cae36c into main Dec 19, 2023
5 checks passed
@octogonz octogonz deleted the octogonz/ae-ts-5.3.0-beta branch December 19, 2023 23:32
@octogonz octogonz changed the title Update API Extractor to support TypeScript 5.3.3 [api-extractor ] Update API Extractor to support TypeScript 5.3.3 Dec 19, 2023
@octogonz octogonz changed the title [api-extractor ] Update API Extractor to support TypeScript 5.3.3 [api-extractor] Update API Extractor to support TypeScript 5.3.3 Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

[api-extractor] ts.getResolvedModule with TypeScript 5.3
4 participants