Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[heft] Improve logging by setting a task name on the task operation #4468

Conversation

bartvandenende-wm
Copy link
Contributor

Summary

Fixes #4467

Details

This PR fixes the heft console print New run requested by unknown task, that could be observed for incremental heft builds.

The expected behaviour is for heft to print the task name that triggered requestRun, for example New run requested by typescript. This improves the ability for teams to diagnose issues when unexpectedly re-builds are encountered.

The fix is passing an explicit name option when the task Operations is initialised.

How it was tested

Manually tested:

  1. cd 'rushstack/build-tests-samples/heft-webpack-basic-tutorial'
  2. rush build --to .
  3. rushx start
  4. Make a file change in the src folder
  5. Observe the console print New run requested by typescript

Impacted documentation

N/A

@octogonz
Copy link
Collaborator

octogonz commented Jan 2, 2024

I've shared a possible alternative approach in a separate PR. See the issue #4467 discussion for details.

@bartvandenende-wm
Copy link
Contributor Author

closing in favour of #4469

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

[heft] heft watch mode always logs the re-run requestor task as unknown
2 participants