Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[terminal] Fix a phantom dependency on "colors" #4527

Merged
merged 7 commits into from
Feb 20, 2024
Merged

[terminal] Fix a phantom dependency on "colors" #4527

merged 7 commits into from
Feb 20, 2024

Conversation

octogonz
Copy link
Collaborator

Summary

Fixes #4525

Details

Fix this error that will occur sometimes when invoking Heft, Rush, or any other library that depends on the updated @rushstack/terminal after PR #3176

Error: Cannot find module 'colors/safe'
Require stack:
- /workspaces/the-wireguard-effect/node_modules/.pnpm/@rushstack+terminal@0.8.0_@types+node@20.11.19/node_modules/@rushstack/terminal/lib/ConsoleTerminalProvider.js
- /workspaces/the-wireguard-effect/node_modules/.pnpm/@rushstack+terminal@0.8.0_@types+node@20.11.19/node_modules/@rushstack/terminal/lib/index.js

@octogonz
Improve "rush scan" to analyze APIs such as "Import.lazy()" and "awai…
72b492c 
…t import()"
@octogonz
Fix #4525 regression where @rushstack/terminal did not declare its …
d735bf6 
…dependency on `colors`
@octogonz
Remove deadwood dependencies detected using "rush scan":
fa0f2eb 
- Heft no longer needs Chokidar
- Lockfile Explorer no longer uses FluentUI
- node-core-library no longer uses colors
@octogonz
rush update
23d37de
@octogonz
rush rebuild
ac53b43
@octogonz octogonz mentioned this pull request Feb 20, 2024
Closed
@octogonz octogonz merged commit 1f6b556 into main Feb 20, 2024
5 checks passed
@octogonz octogonz deleted the octogonz/fix-package-deps branch February 20, 2024 21:35
@octogonz octogonz mentioned this pull request Feb 20, 2024
Merged
@octogonz
Copy link
Collaborator Author

🚀 We've published @rushstack/heft@0.65.1 and @rushstack/terminal@0.8.1 which should resolve the problem.

Thank you @leonitousconforti for reporting this problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iclanton iclanton iclanton approved these changes

@apostolisms apostolisms Awaiting requested review from apostolisms apostolisms is a code owner

@D4N14L D4N14L Awaiting requested review from D4N14L D4N14L is a code owner

@dmichon-msft dmichon-msft Awaiting requested review from dmichon-msft dmichon-msft is a code owner

@patmill patmill Awaiting requested review from patmill patmill is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[heft] Error: Cannot find module 'colors/safe'
2 participants
@octogonz @iclanton