[rush] Skip determining merge base if given git hash #4592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenrick95
requested review from
iclanton,
octogonz,
apostolisms,
D4N14L and
dmichon-msft
as code owners
iclanton
changed the title
kenrick95
force-pushed
the
kenrick/skip-merge-base
branch
from
d9bc188
to
17a6383
Compare
dmichon-msft
approved these changes
Apr 23, 2024
octogonz
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4589
Details
In
libraries/rush-lib/src/logic/ProjectChangeAnalyzer.ts, I added a logic to skip determining merge base if the given "targetBranchName" is already a git commit hashHow it was tested
I tested the local build against my own repro in #4589 and it works as expected. However I'd like some advise too on how to write test for this change.
Impacted documentation
N/A