-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rush] Fix an issue about dependency using NPM alias with workspace protocol is not selected by selectors (eg: --to .) #4731
Merged
iclanton
merged 9 commits into
microsoft:main
from
depressedX:fix/alias-workspace-protocol-selector
Jun 12, 2024
Merged
[rush] Fix an issue about dependency using NPM alias with workspace protocol is not selected by selectors (eg: --to .) #4731
iclanton
merged 9 commits into
microsoft:main
from
depressedX:fix/alias-workspace-protocol-selector
Jun 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
depressedX
requested review from
iclanton,
octogonz,
apostolisms,
D4N14L and
dmichon-msft
as code owners
May 22, 2024 07:56
octogonz
reviewed
May 23, 2024
@microsoft-github-policy-service agree |
noticed other codes that invoked rushstack/libraries/rush-lib/src/api/RushConfiguration.ts Lines 909 to 919 in cfc8ded
|
iclanton
approved these changes
Jun 12, 2024
common/changes/@microsoft/rush/fix-alias-workspace-protocol-selector_2024-05-24-07-55.json
Outdated
Show resolved
Hide resolved
iclanton
force-pushed
the
fix/alias-workspace-protocol-selector
branch
from
June 12, 2024 19:30
7efc865
to
e0b36d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
currently, when declaring dependency with
NPM
alias with workspace protocolworkspace:
, the dependency won't be picked up by selectors (eg: --to-except)eg:
"alias-for-my-controls": "workspace:my-controls@^1.0.0"
Details
2 dependencies added in package.json:
when running
rush list --to-except my-app
the output will only print
my-toolchain
, whilemy-controls
is absent.How it was tested
TODO
Impacted documentation