[rush] malformed package.json by explicitly setting jsonSyntax to strict #4813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenrick95
requested review from
iclanton,
octogonz,
apostolisms,
D4N14L and
dmichon-msft
as code owners
Co-authored-by: David Michon <dmichon@microsoft.com>
Co-authored-by: David Michon <dmichon@microsoft.com>
D4N14L
approved these changes
Jun 28, 2024
iclanton
changed the title
iclanton
approved these changes
Jul 1, 2024
common/changes/@microsoft/rush/kenrick-fix-rush-add_2024-06-27-02-39.json
Outdated
Show resolved
Hide resolved
common/changes/@rushstack/node-core-library/kenrick-fix-rush-add_2024-06-27-02-39.json
Outdated
Show resolved
Hide resolved
common/changes/@rushstack/node-core-library/kenrick-fix-rush-add_2024-06-27-02-39.json
Outdated
Show resolved
Hide resolved
|
🚀 Finally released with Rush 5.129.7 -- thanks for your patience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Attempt to fix #4811
Details
I investigated and found out that when saving JSON with "jju.update", it always use Json5 mode. This may cause issue when updating things that expect strict JSON like package.json.
So the fix here is to pass a
jsonSyntaxoption to letPackageJsonEditoruse thatJsonSyntax.Strictmode.How it was tested
I build locally and it works on the repro: https://github.com/kenrick95/rush-repro-rush-add-malformed-package-json
Impacted documentation