Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Exec Results pane for SQL support #890

Merged
merged 3 commits into from
May 31, 2024
Merged

Add Exec Results pane for SQL support #890

merged 3 commits into from
May 31, 2024

Conversation

iseabock
Copy link
Contributor

Motivation and Context

With support SQL added, this PR adds the ability to inspect the intent, search query and search results.

Screenshot 2024-05-29 172457

Contribution Checklist

  • I have built and tested the code locally and in a deployed app
  • For frontend changes, I have pulled the latest code from main, built the frontend, and committed all static files.
  • This is a change for all users of this app. No code or asset is specific to my use case or my organization.
  • I didn't break any existing functionality 馃槃

@iseabock iseabock requested a review from abhahn May 30, 2024 20:19
abhahn
abhahn requested changes May 30, 2024
View reviewed changes
Copy link
Member

@abhahn abhahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great, and really appreciate your work on this! I just had a couple of small comments.

frontend/package.json Outdated Show resolved Hide resolved
frontend/src/components/Answer/Answer.tsx Show resolved Hide resolved
Ian Seabock (Centific Technologies Inc) added 2 commits May 30, 2024 15:11
abhahn
abhahn approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@abhahn abhahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@abhahn abhahn merged commit cb65219 into main May 31, 2024
8 checks passed
@abhahn abhahn deleted the NO-TASK-add-exec-results-pane-for-sql-support branch May 31, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhahn abhahn abhahn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iseabock @abhahn