Eable entra ID authentication #910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
June 10, 2024 09:07
abhahn
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
Overall looks great, thanks a lot for this contribution!
I just have a few very minor nitpicks about capitalizations in the README. I'll go ahead and approve it now, and will keep an eye out for any additional changes you might make to the README for reapproval.
ConnieLi-Cook
pushed a commit
to sydneybeckcook/sample-app-aoai-chatGPT-customcookgpt
that referenced
this pull request
Jul 17, 2024
Co-authored-by: Denis Oliana <denis.oliana@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Currently access to Azure OpenAI requires a key to be used. I wanted to enable entra ID based authentication. There is an issue for this: #190
Description
Contribution Checklist