Enabling GitHubAppCredentials dynamic validator #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddynaka
force-pushed
the
users/ednakamu/github-app-credentials-dynamic-validation
branch
from
0170894
to
f4f52f0
Compare
Creasting helper, updating tests, and md file Renaming method. Improving SquarePat validator Adding timeout to postgres Trying to fix concurrency between tests Validator tests collection (httponly) Updating xunit runner to prevent collisions Updating BuildAndTest.ps1 Trying to fix determinism for tests Running Debug mode in CI (fixing coverage paths) Updating product.props Fixing build reverting to release
eddynaka
force-pushed
the
users/ednakamu/github-app-credentials-dynamic-validation
branch
from
61e133b
to
f7a90c6
Compare
eddynaka
commented
Aug 1, 2021
| @@ -0,0 +1,4 @@ | |||
| { | |||
| "$schema": "https://xunit.net/schema/current/xunit.runner.schema.json", | |||
| "maxParallelThreads": 1 | |||
There was a problem hiding this comment.
This is only needed during tests because we are injecting what we want to receive for each test
|
We need a ReleaseNotes.md file at the root of the enlistment! It should make clear note of any changes that add to analysis or which drop false positives, etc.! there are many things we haven't documented properly, so we can do this in a follow-on change. |
eddynaka
deleted the
users/ednakamu/github-app-credentials-dynamic-validation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.