Crc helpers #518
Merged
Crc helpers #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelcfanning
commented
Aug 1, 2021
| @@ -1,6 +1,15 @@ | |||
| # Remove the line below if you want to inherit .editorconfig settings from higher directories | |||
| root = true | |||
|
|
|||
| # Ignore paths | |||
| [/sarif-pattern-matcher/Src/sarif-sdk/src/sarif/Autogenerated/**] | |||
There was a problem hiding this comment.
what are you trying to trigger here?
for this to work we would need to change the sarif-sdk and place a file like this in the autogenerated folder.
There was a problem hiding this comment.
The IDE is showing analysis errors for the Autogenerated folder. We can't fix errors in this code: it is auto-generated.
michaelcfanning
commented
Aug 1, 2021
| @@ -5,7 +5,7 @@ | |||
| <Import Project="$(MSBuildThisFileDirectory)..\..\..\Targets\build.plugins.props" /> | |||
|
|
|||
| <PropertyGroup Label="AssemblyAttributes"> | |||
| <TargetFrameworks>netstandard2.0;net472</TargetFrameworks> | |||
| <TargetFrameworks>netstandard2.1;net472</TargetFrameworks> | |||
There was a problem hiding this comment.
we started with 2.0, but the other package got a higher dependency that required 2.1.
There was a problem hiding this comment.
In the security.tests test, can you change to netstandard2.1? (the strings in the unit tests)
that will probably fix the build issue
…ing between different classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a CRC algorithm + tests and switch ADO to use it.
@eddynaka