Making HttpClient static again when not using in tests #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (httpClient == null) | ||
| // The httpClient is the property that will be used for tests only. | ||
| if (httpClient != null) | ||
| { |
There was a problem hiding this comment.
shouldn't we be using this. as a prefix here? to make it clear we're referencing instance data on the class?
i like this pattern, or we could use m_ as a prefix to make that distinction clear. what do we do elsewhere?
| @@ -324,24 +327,30 @@ internal void SetHttpClient(HttpClient client) | |||
|
|
|||
| protected HttpClient CreateOrUseCachedHttpClient() | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@michaelcfanning , this is the change we talked yesterday at night.
We will have two httpclients, one that is static and one private.
The static will be normally used.
The private will only be used during tests.