Improving regex patterns #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddynaka
commented
Aug 11, 2021
| @@ -7,71 +7,12 @@ | |||
| Iv1.01234567testtest | |||
| </GitHubId> | |||
|
|
|||
| ******************************************************************************** | |||
There was a problem hiding this comment.
cleaning up duplicated tests since we have intrafile search for this rule #ByDesign
eddynaka
commented
Aug 11, 2021
Src/Changelog.md
Outdated
| @@ -0,0 +1,664 @@ | |||
| # Changelog | |||
There was a problem hiding this comment.
Why do we have two files? Are we really going to maintain change log in this way, manually? i.e., describe the developer maintenance process to me.
There was a problem hiding this comment.
the changelog is something auto-generated
the releasehistory is basically the relevant changes.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is replacing \b for the following patterns:
(?:[^some_pattern]|^)
(?:[^some_pattern]|$)