Checking unknown host exception for PostgreSqlCredential #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an if statement that catches if the secret is not accessible from the public. The credentials may or may not be valid, but we can't test that.
eddynaka
reviewed
Aug 26, 2021
Src/Plugins/Security/SEC101_038.PostgreSqlCredentialsValidator.cs
Outdated
Show resolved
Hide resolved
eddynaka
reviewed
Aug 26, 2021
eddynaka
changed the title
eddynaka
reviewed
Aug 26, 2021
Src/ReleaseHistory.md
Outdated
| [#541](https://github.com/microsoft/sarif-pattern-matcher/pull/541) | ||
| - Tool Improvement: Add a check for PostgreSql instances that are not reachable from external networks. | ||
| [#545](https://github.com/microsoft/sarif-pattern-matcher/pull/544) |
eddynaka
reviewed
Aug 26, 2021
Src/ReleaseHistory.md
Outdated
| [#541](https://github.com/microsoft/sarif-pattern-matcher/pull/541) | ||
| - Tool Improvement: Add a check for PostgreSql instances that are not reachable from external networks. |
There was a problem hiding this comment.
Tool Improvement: Add a check for PostgreSql instances that are not reachable from external networks.
the question we should make: what would happen after this change?
would we improve get more results/more live secrets/etc?
I think, we should change to something like: "UER: Added a check for PostgreSql instances that are not reachable from external networks reducing unexpected exceptions."
UER = eliminate unhandled exceptions in rules
this is explaining very detailed what we are doing and what will happen.
eddynaka
changed the title
eddynaka
approved these changes
Aug 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an if statement that catches if the database the secret points to is not accessible from the public. The credentials may or may not be valid, but we can't test that.
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
ReleaseHistory.mdupdated for non-trivial changes