Using latest windows SDK to compile RE2 libraries #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here are two questions I always ask: 1. Where are the release notes 2. where are the tests? I understand why tests don't appear here. :) |
michaelcfanning
approved these changes
Apr 11, 2022
|
What you need to do is to make the release pipeline use a well-known Windows SDK and we need to document that in the PR notes. |
eddynaka
added a commit
that referenced
this pull request
Apr 11, 2022
michaelcfanning
added a commit
that referenced
this pull request
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This change will allow us to use the latest windows SDK installed instead of hardcoding a specific version.
For significant contributions please make sure you have completed the following items:
ReleaseHistory.mdupdated for non-trivial changes