Improving AzureFunctions and build project #91
Conversation
| /// </param> | ||
| /// <returns>Return the validation state.</returns> | ||
| #pragma warning disable IDE0060 // Remove unused parameter | ||
| public static string IsValid( | ||
| ref string matchedPattern, | ||
| ref Dictionary<string, string> groups, | ||
| ref bool performDynamicValidation, | ||
| ref string failureLevel) | ||
| ref string failureLevel, | ||
| ref string fingerprint) |
There was a problem hiding this comment.
ref string fingerprint [](start = 12, length = 22)
We were missing the fingerprint (fixed) #ByDesign
There was a problem hiding this comment.
i see the fingerprints generated in result with this change, do we intended to show them?
e.g.
"fingerprints": {
"SecretFingerprint/v1": "[pat/vs=h5lxeqkz4zujkyvzg5emkejgelxj4x64tvyzclprekuloawbbz5q]"
}
In reply to: 553894953 [](ancestors = 553894953)
There was a problem hiding this comment.
| @@ -1,4 +1,5 @@ | |||
| { | |||
| "ValidatorsAssemblyName": "Security.dll", | |||
There was a problem hiding this comment.
"ValidatorsAssemblyName": "Security.dll", [](start = 2, length = 41)
We were missing the assembly name (fixed) #ByDesign
| @@ -36,6 +36,12 @@ public class AnalyzeCommand : MultithreadedAnalyzeCommandBase<AnalyzeContext, An | |||
| SearchDefinitions definitions = | |||
| JsonConvert.DeserializeObject<SearchDefinitions>(searchDefinitionsText); | |||
|
|
|||
| // This would skip files that does not look like rules. | |||
| if (definitions == null || definitions.Definitions == null) | |||
There was a problem hiding this comment.
if (definitions == null || definitions.Definitions == null) [](start = 16, length = 59)
We might find files that aren't rules. If that happen, the project fails. With this, we will just continue. #ByDesign
| @@ -35,7 +36,7 @@ public static class HttpAnalyzeFunction | |||
| SarifLog sariflog = await Task.Run(() => SpamAnalyzer.Analyze(sourceFilePath, text, definitionsFolder)); | |||
|
|
|||
| log.LogInformation($"Completed analyzing file {file.FileName}"); | |||
| return new JsonResult(sariflog); | |||
| return new OkObjectResult(sariflog); | |||
There was a problem hiding this comment.
OkObjectResult [](start = 31, length = 14)
Changing from JsonResult to OkObjectResult, we prevent object -> string. #ByDesign
| <ProjectReference Include="..\Sarif.PatternMatcher\Sarif.PatternMatcher.csproj" /> | ||
| </ItemGroup> | ||
| <Target Name="CopyingSpamRules" BeforeTargets="Build"> | ||
| <Copy SourceFiles="@(SpamFiles)" DestinationFolder="$(MSBuildThisFileDirectory)\Rules\" OverwriteReadOnlyFiles="true" SkipUnchangedFiles="false" /> | ||
| </Target> |
There was a problem hiding this comment.
We won't need this, since I added a project reference to always publish the security.csproj as well #ByDesign
| @@ -15,6 +16,7 @@ namespace Microsoft.CodeAnalysis.Sarif.PatternMatcher.Function | |||
| internal static class SpamAnalyzer | |||
| { | |||
| internal static readonly IFileSystem FileSystem; | |||
| internal static ISet<Skimmer<AnalyzeContext>> Skimmers; | |||
There was a problem hiding this comment.
internal static ISet<Skimmer> Skimmers [](start = 8, length = 54)
Added a naive cache to prevent loading rules all the time. Since the rules won't change unless we publish a new version, that can be read once. #ByDesign
|
@yongyan-gh , you can take this branch and add the fix that you checked with Jeff (merging the two functions in one). Let me know what do you think. #Closed |
|
Added the change In reply to: 756711861 [](ancestors = 756711861) |
No description provided.