Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multitool crashes on launch: Can't find Command.Line.dll #1487

Closed
ghost opened this issue May 9, 2019 · 5 comments
Closed

Multitool crashes on launch: Can't find Command.Line.dll #1487

ghost opened this issue May 9, 2019 · 5 comments

Comments

@ghost
Copy link

ghost commented May 9, 2019

c:\dev\sarif\sarif-sdk>bld\bin\AnyCPU_Release\Sarif.Multitool\net461\Sarif.Multitool.exe

Unhandled Exception: System.IO.FileLoadException: Could not load file or assembly
'CommandLine, Version=2.2.1.0, Culture=neutral, PublicKeyToken=de6f01bd326f8c32'
or one of its dependencies. The located assembly's manifest definition does not match
the assembly reference. (Exception from HRESULT: 0x80131040)
@ghost ghost added the bug label May 9, 2019
@ghost ghost self-assigned this May 9, 2019
@ghost
Copy link
Author

ghost commented May 9, 2019

I can run the multitool from within VS (I can F5 the project and the tool runs).

@ghost
Copy link
Author

ghost commented May 9, 2019

This seems to be the problem:

C:\dev\sarif\sarif-sdk>findstr /s CommandLine *.csproj
...
src\Sarif.Driver\Sarif.Driver.csproj:    <PackageReference Include="CommandLineParser" Version="2.2.1" />
src\Sarif.Multitool\Sarif.Multitool.csproj:    <PackageReference Include="CommandLineParser" Version="2.5.0" />

@ghost
Copy link
Author

ghost commented May 9, 2019

And this change came in with 6ba091a, "Multitool: Enable cross-platform 'dotnet tool' support (#1474)"

@ghost
Copy link
Author

ghost commented May 9, 2019

This explains why it runs in VS, because VS runs the dotnet core version, and that works. But that change broke the .NET Framework version, and didn't test it.

@michaelcfanning
Copy link
Member

ok, so big hole in testing here. also, clearly need to update nuget asap

ghost pushed a commit that referenced this issue May 9, 2019
@ghost ghost closed this as completed in 1ab0ab4 May 9, 2019
ghost pushed a commit that referenced this issue May 9, 2019
ghost pushed a commit that referenced this issue May 9, 2019
@ghost ghost added the resolved-fixed label Jun 17, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant