Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CS converter doesn't produce threadFlowLocation.location #1530

Closed
ghost opened this issue Jun 12, 2019 · 0 comments
Closed

CS converter doesn't produce threadFlowLocation.location #1530

ghost opened this issue Jun 12, 2019 · 0 comments

Comments

@ghost
Copy link

ghost commented Jun 12, 2019

When the CS converter translates a sequence of propagation-event elements into a threadFlow, it populates each threadFlowLocation.stack from the propagation-event's stack sub-element. The converter also takes the propagation-event's signature sub-element and places it at the top of the stack.

But the converter does not populate threadFlowLocation.location, which confuses the VS Code Viewer, which expects location to be present. Sure, we could "fix" the viewer, but really, signature does specify the location, and we should populate it.

@michaelcfanning @rscrivens FYI

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

0 participants