Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multitool transform mishandles dottedQuadFileVersion #1532

Closed
ghost opened this issue Jun 12, 2019 · 1 comment
Closed

Multitool transform mishandles dottedQuadFileVersion #1532

ghost opened this issue Jun 12, 2019 · 1 comment
Labels
area-conversion area-multitool Multitool command implementations bug m156 resolved-fixed

Comments

@ghost
Copy link

ghost commented Jun 12, 2019 •
edited by ghost
Loading

The Roslyn compiler emits SARIF v1.0 with tool.fileVersion = "3.100.19.26603 (9d80dea7)". The multitool transform command blithely copies it to tool.driver.dottedQuadFileVersion -- but the new name makes clear that this is wrong.

What should the transformer do when fileVersion doesn't match the expected format of dottedQuadFileVersion?

Well, if fileVersion does contain a substring of the form n.n.n.n, we should probably populate dottedQuadFileVersion with that. But what should we do with the rest?
@ghost ghost added the bug label Jun 12, 2019
@ghost ghost self-assigned this Jun 12, 2019
@ghost ghost added area-conversion area-multitool Multitool command implementations labels Aug 14, 2019
@ghost
Copy link
Author

ghost commented Aug 14, 2019 •
edited by ghost
Loading

Let's put it in the property bag under "sarifv1/toolFileVersion".

ghost pushed a commit that referenced this issue Aug 15, 2019
Fix #1532: Multitool transform mishandles dottedQuadFileVersion.
7a3e1f2 
The SARIF v1 spec does not specify a format for tool.fileVersion (although on the Windows platform, the spec anticipated that it would be of the form n.n.n.n where each n is one or more decimal digits).

The SARIF v2 spec is more prescriptive: it defines a property toolComponent.dottedQuadFileVersion with exactly that format. So if the v1 file contained a tool.fileVersion in any other format, the best we can do is put it in the property bag.
@ghost ghost closed this as completed in 1db9484 Aug 15, 2019
@ghost ghost added the resolved-fixed label Aug 15, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-conversion area-multitool Multitool command implementations bug m156 resolved-fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@michaelcfanning