Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SarifCurrentToVersionOneVisitor emits an empty run.stableId #1557

Closed
ghost opened this issue Jul 1, 2019 · 0 comments
Closed

SarifCurrentToVersionOneVisitor emits an empty run.stableId #1557

ghost opened this issue Jul 1, 2019 · 0 comments
Labels
bug urgent

Comments

@ghost
Copy link

ghost commented Jul 1, 2019

Urgent. This breaks an internal customer. @michaelcfanning @harleenkohli FYI.
@ghost ghost added bug urgent labels Jul 1, 2019
@ghost ghost self-assigned this Jul 1, 2019
@ghost ghost changed the title SarifCurrentToVersionOneVisitor emits an empty stableId SarifCurrentToVersionOneVisitor emits an empty run.stableId Jul 1, 2019
ghost pushed a commit that referenced this issue Jul 1, 2019
Fix #1557: current-to-v1 converter drops run.id and emits empty stabl…
31b4c05 
…eId.

Also:
- Fix Sarif project file that made ReleaseHistory.md show up in the VS editor with a file name of "false".
@ghost ghost mentioned this issue Jul 1, 2019
Merged
@ghost ghost closed this as completed in 5ebe27b Jul 2, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug urgent
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants