Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multitool Transform can't upgrade "http://json.schemastore.org/sarif-2.1.0-rtm.1" schema #1584

Closed
rscrivens opened this issue Jul 24, 2019 · 0 comments
Closed

Multitool Transform can't upgrade "http://json.schemastore.org/sarif-2.1.0-rtm.1" schema #1584

rscrivens opened this issue Jul 24, 2019 · 0 comments
Labels
area-conversion area-multitool Multitool command implementations bug m156 resolved-fixed

Comments

@rscrivens
Copy link
Contributor

Using the latest published multitool, to transform an older sarif filethat has a schema of "http://json.schemastore.org/sarif-2.1.0-rtm.1" the multitool does nothing.

It looks like #1501 updated the schema format to: "https://schemastore.azurewebsites.net/schemas/json/sarif-".

But it didn't account for rtm.1 still being the old schema url format in PrereleaseCompatibilityTransformer.cs:

switch (schemaSubVersion)
{
-       case "http://json.schemastore.org/sarif-2.1.0-rtm.1":
+       case "https://schemastore.azurewebsites.net/schemas/json/sarif-2.1.0-rtm.1.json":
        {
@rscrivens rscrivens mentioned this issue Jul 24, 2019
Merged
rscrivens added a commit to microsoft/sarif-vscode-extension that referenced this issue Jul 24, 2019
@rscrivens
Update sarif schema version to 2.1.0 rtm.4 (#191)
3fdda30 
Updated the:
* @types/sarif package
* multitool
* supported schema version for when to update using multitool 
   * Includes a work around for microsoft/sarif-sdk#1584
@ghost ghost added area-conversion area-multitool Multitool command implementations bug labels Aug 17, 2019
@ghost ghost self-assigned this Aug 17, 2019
ghost pushed a commit that referenced this issue Aug 17, 2019
Fix #1584: Multitool Transform can't upgrade "http://json.schemastore…
7c480d1 
….org/sarif-2.1.0-rtm.1" schema
@ghost ghost closed this as completed in 439258b Aug 19, 2019
@ghost ghost mentioned this issue Aug 22, 2019
Merged
@ghost ghost added the resolved-fixed label Aug 22, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-conversion area-multitool Multitool command implementations bug m156 resolved-fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaelcfanning @rscrivens