Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UriConverter crashes with NullReferenceException on empty URI #1632

Closed
ghost opened this issue Aug 9, 2019 · 0 comments · Fixed by microsoft/sarif-visualstudio-extension#103
Closed

UriConverter crashes with NullReferenceException on empty URI #1632

ghost opened this issue Aug 9, 2019 · 0 comments · Fixed by microsoft/sarif-visualstudio-extension#103
Labels
bug urgent viewer-vsix

Comments

@ghost
Copy link

ghost commented Aug 9, 2019 •
edited by ghost
Loading

Example: "helpUri": ""

Strictly speaking this is invalid SARIF (the value is not a URI) but a prominent SARIF producer creates this output.

Instead of crashing, just don't populate the property (return null).

This is the root cause of microsoft/sarif-visualstudio-extension#85.
@ghost ghost self-assigned this Aug 9, 2019
ghost pushed a commit that referenced this issue Aug 9, 2019
Fix #1632: UriConverter crashes with NullReferenceException on empty URI
88485ac 
The empty string is a valid relative URI although not a valid absolute URI (per RFC 3986).
@ghost ghost closed this as completed in fbe73e6 Aug 9, 2019
@ghost ghost mentioned this issue Aug 9, 2019
Merged
ghost pushed a commit to microsoft/sarif-visualstudio-extension that referenced this issue Aug 9, 2019
Fix #85: Can't open files containing empty string URIs (#103)
a8f2874 
This PR updates the VSIX to use version 2.1.13 of the SARIF SDK, which fixes microsoft/sarif-sdk#1632, the root cause of #85.
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug urgent viewer-vsix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #85: Can't open files containing empty string URIs microsoft/sarif-visualstudio-extension
0 participants