Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require --force if --inline is specified. #1642

Closed
ghost opened this issue Aug 14, 2019 · 0 comments
Closed

Don't require --force if --inline is specified. #1642

ghost opened this issue Aug 14, 2019 · 0 comments
Labels
area-multitool Multitool command implementations design-improvement

Comments

@ghost
Copy link

ghost commented Aug 14, 2019

Observe this output:

C:> Sarif.Multitool transform --inline test.sarif
The output file 'test.sarif' already exists. Use --force to overwrite.

Since --inline means "overwrite the input file", there's no reason to require force. In my recent work on #1340 I found that some commands do work in the expected way, so this is just another example of non-uniformity among the Multitool command implementations. #1631 is another example.

@rtaket @michaelcfanning FYI

@ghost ghost added design-improvement area-multitool Multitool command implementations labels Aug 14, 2019
@ghost ghost self-assigned this Aug 17, 2019
ghost pushed a commit that referenced this issue Aug 18, 2019
@ghost ghost closed this as completed in 1fa26cc Aug 22, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-multitool Multitool command implementations design-improvement
Projects
None yet
Development

No branches or pull requests

0 participants