Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SarifLogger does not handle sub-rules #1668

Closed
ghost opened this issue Sep 4, 2019 · 0 comments
Closed

SarifLogger does not handle sub-rules #1668

ghost opened this issue Sep 4, 2019 · 0 comments
Labels
bug

Comments

@ghost
Copy link

ghost commented Sep 4, 2019 •
edited by ghost

Given a Result object result with result.RuleId == "TEST0001/1", and a ReportingDescriptor object rule with rule.Id == "TEST0001", the call

SarifLogger logger = ... ;
...
logger.Log(rule, result);

fails with the message:

Error: System.ArgumentException: The rule id 'TEST0001/1' specified by the result does not
match the actual id of the rule 'TEST0001'
@ghost ghost added the bug label Sep 4, 2019
ghost pushed a commit that referenced this issue Sep 4, 2019
Fix #1668: SarifLogger doesn't handle sub-rules.
64ab7e2
@ghost ghost closed this as completed in be49951 Sep 6, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants