Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tool.CreateFromAssembly mishandles dottedQuadFileVersion #1728

Closed
ghost opened this issue Dec 14, 2019 · 0 comments
Closed

Tool.CreateFromAssembly mishandles dottedQuadFileVersion #1728

ghost opened this issue Dec 14, 2019 · 0 comments
Labels
bug resolved-fixed

Comments

@ghost
Copy link

ghost commented Dec 14, 2019 •
edited by ghost
Loading

If FileVersionInfo.FileVersion is something like this:

"18.255.65000.0 built by: MY-MACHINE"

... then it accepts the entire string. The spec requires only the four dot-separated integer components.

@michaelcfanning FYI
@ghost ghost added the bug label Dec 14, 2019
ghost pushed a commit that referenced this issue Dec 14, 2019
Fix #1728: Tool.CreateFromAssembly mishandles dottedQuadFileVersion
c28000e
@ghost ghost self-assigned this Dec 15, 2019
@ghost ghost added the resolved-fixed label Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug resolved-fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants