Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge the multitool 'transform' command into the 'rewrite' command. #2227

Closed
michaelcfanning opened this issue Jan 9, 2021 · 0 comments · Fixed by #2252
Closed

Merge the multitool 'transform' command into the 'rewrite' command. #2227

michaelcfanning opened this issue Jan 9, 2021 · 0 comments · Fixed by #2252

Comments

@michaelcfanning
Copy link
Member

The transform command converts v1 to v2 and back, and upgrades pre-release v2 to current v2. The rewrite provides arbitrary rewriting of logs, such as pretty printing. These commands can be merged into a common rewrite command.

@eddynaka
@jameswinkler

James, I think this could be a good next issue for you. A step up in complexity from the spot fixes you knocked out in short order. But no net new code, just a refactoring to merge existing. Glad to get on a call with you and Eddy to discuss approach.
@jameswinkler jameswinkler mentioned this issue Jan 21, 2021
Merged
michaelcfanning added a commit that referenced this issue Jan 28, 2021
@jameswinkler @eddynaka @michaelcfanning
#2227 Move Transform functionality into Rewrite (#2252)
689b73d 
* Move some code from TransformCommand to DriverExtensionMethods and correct unit tests

* Refatoring, add a bunch of functionality to RewriteCommand

* Add some comments, new method "TransformationNecessary"

* Checkin preliminary changes, 4 unit tests fail because Rewrite can't handle any version except 2.

* Transform to version 2 first, rewrite, then if needed, transform to version 1

* Address failing unit tests, refactor per discussions.  Now transforming to V2 first always

* Delete transform command entirely

* One last comment

* Restore constructor

* Default to current version, undo reordering of commands, and consolidate writes while transforming

* Fix formatting

* Create issues for TODOs

* Add info to ReleaseHistory

* Add one more issue for TODO

* Remove redundant assignments

* correct release history

* Update ReleaseHistory.md

Co-authored-by: Eddy Nakamura <eddynaka@gmail.com>
Co-authored-by: Michael C. Fanning <michael.fanning@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#2227 Move Transform functionality into Rewrite microsoft/sarif-sdk
1 participant
@michaelcfanning