adding inline externalpropertyfiles : [https://github.com/oasis-tcs/sarif-spec/issues/321] #1319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Mar 6, 2019
| @@ -27,6 +27,16 @@ | |||
| } | |||
| }, | |||
|
|
|||
| "inlineExternalPropertyFiles": { | |||
| "description": "References to external property files that share data between runs.", | |||
There was a problem hiding this comment.
References [](start = 22, length = 10)
@michaelcfanning @harleenkohli
I'm writing the change draft for this now. This property is not an array of references to external property files; it is an array each element of which contains the contents of an external property file. It's as if you took an actual external property file and copy/pasted its contents into one of the array elements.
How about this for the description:
"An array of externalPropertyFile objects containing data that is shared among the runs in the log file."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.