Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading .NET Framework from .NET45 to .NET452 #2135

Merged
merged 3 commits into from
Oct 28, 2020

Conversation

eddynaka
Copy link
Collaborator

@eddynaka eddynaka commented Oct 27, 2020

Fixes #417

Changes:

  • upgraded all projects below .NET Framework 4.5.2 to .NET Framework 4.5.2
  • added missing projects to sample solution

@eddynaka eddynaka self-assigned this Oct 27, 2020
@@ -1,5 +1,8 @@
# SARIF Package Release History (SDK, Driver, Converters, and Multitool)

* FEATURE: SDK BREAKING CHANGE: Upgrade from .NET Framework 4.5 to .NET Framework 4.5.2 [#2135](https://github.com/microsoft/sarif-sdk/pull/2135)
Copy link
Member

@michaelcfanning michaelcfanning Oct 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FEATURE: SDK BREAKING CHANGE [](start = 2, length = 28)

We usually call this kind of change 'PACKAGE BREAKING'. i.e., it is a compatibility break at the package level. It's not a great name. :) But that's the pattern. #Resolved

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just updated!


In reply to: 513101256 [](ancestors = 513101256)

Copy link
Member

@michaelcfanning michaelcfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@michaelcfanning michaelcfanning merged commit bf54b26 into master Oct 28, 2020
@michaelcfanning michaelcfanning deleted the users/ednakamu/upgrading-to-net452 branch October 28, 2020 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can we drop the SDK to .NET 4.5
2 participants