Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Github sourcelink #2148

Merged
merged 12 commits into from
Nov 10, 2020
Merged

Conversation

eddynaka
Copy link
Collaborator

@eddynaka eddynaka commented Nov 9, 2020

@eddynaka
Copy link
Collaborator Author

eddynaka commented Nov 9, 2020

Old package:
image

New Package:
image
image

@eddynaka eddynaka self-assigned this Nov 9, 2020
@eddynaka eddynaka marked this pull request as ready for review November 10, 2020 09:30
@@ -96,5 +97,9 @@

<Import Project="ToDotNet\ToDotNet.targets" />

<ProjectExtensions><VisualStudio><UserProperties CodeGenHints_1json__JSONSchema="http://json.schemastore.org/asmdef" /></VisualStudio></ProjectExtensions>
<ProjectExtensions>
<VisualStudio>
Copy link
Member

@michaelcfanning michaelcfanning Nov 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VisualStudio [](start = 5, length = 12)

This can be deleted from merge, I think. #Closed

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just removed! thank you


In reply to: 520763919 [](ancestors = 520763919)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge away!


In reply to: 520765577 [](ancestors = 520765577,520763919)

Copy link
Member

@michaelcfanning michaelcfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@eddynaka eddynaka merged commit 6443453 into master Nov 10, 2020
@eddynaka eddynaka deleted the users/ednakamu/enabling-github-sourcelink branch November 10, 2020 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants